Allow existing nc-root element #1176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit fd8d73a |
|
Deploy preview for cms-demo ready! Built with commit fd8d73a |
tech4him1
suggested changes
Mar 16, 2018
src/bootstrap.js
Outdated
| document.body.appendChild(el); | ||
| const el = document.getElementById('nc-root'); | ||
| if (!el) { | ||
| document.createElement('div'); |
There was a problem hiding this comment.
This needs to be assigned to el, so that you can append it below.
There was a problem hiding this comment.
Oops, I have that on mine, forgot to push 👍 @tech4him1 good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Allow for the render of an existing root element for the CMS app.
Solves:
Will allow a React app to be able to wrap the CMS component with a react component to be able to include as a route.
Example Test Repo based on create-react-app
- Test plan
yarn builddistassets in your app- Description for the changelog
Allow existing root element
nc-root- A picture of a cute animal (not mandatory but encouraged)
🦈