Markdown editor improvements #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erquhart
commented
Sep 1, 2017
•
erquhart
commented
- remove JIT serialization of markdown widget values
- debounce markdown widget change handler to improve performance
- fix broken editorial workflow (regression from Migrate rich text editor to Slate backed by Unified #254, missing import)
- close heading blocks on Enter
erquhart
commented
Sep 1, 2017
| @@ -1,5 +1,6 @@ | |||
| import uuid from 'uuid'; | |||
| import { actions as notifActions } from 'redux-notifications'; | |||
| import { serializeValues } from '../lib/serializeEntryValues'; | |||
There was a problem hiding this comment.
Missed this in #254.
erquhart
force-pushed
the
markdown-editor-improvements
branch
from
7d8e5b9 to
efd0110
Compare
Benaiah
approved these changes
Sep 1, 2017
| @@ -13,9 +13,8 @@ export default class RawEditor extends React.Component { | |||
| * to plain text before Slate's Plain serializer can convert it to the | |||
| * Slate AST. | |||
There was a problem hiding this comment.
This comment is no longer accurate, since there's no stringification in this method anymore.
| @@ -27,15 +26,16 @@ export default class RawEditor extends React.Component { | |||
| this.setState({ editorState }); | |||
| } | |||
|
|
|||
| onChange = debounce(this.props.onChange, 250); | |||
| @@ -27,15 +26,16 @@ export default class RawEditor extends React.Component { | |||
| this.setState({ editorState }); | |||
| } | |||
|
|
|||
| onChange = debounce(this.props.onChange, 250); | |||
|
|
|||
| /** | |||
| * When the document value changes, serialize from Slate's AST back to plain | |||
| * text (which is Markdown), and then deserialize from that to a Remark MDAST, | |||
| * before passing up as the new value. | |||
There was a problem hiding this comment.
This comment is no longer accurate.
erquhart
force-pushed
the
markdown-editor-improvements
branch
from
efd0110 to
a05f876
Compare
erquhart
force-pushed
the
markdown-editor-improvements
branch
from
a05f876 to
75023d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.