Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential breakage through form_urlencoded #39

Open
PhilippGackstatter opened this issue Mar 10, 2023 · 0 comments
Open

Prevent potential breakage through form_urlencoded #39

PhilippGackstatter opened this issue Mar 10, 2023 · 0 comments

Comments

@PhilippGackstatter
Copy link

PhilippGackstatter commented Mar 10, 2023

Hello,

we would like to point out a potential issue that you might want to prevent. The did-key crate depends on did_url which in turn depends on form_urlencoded. The latter crate is considering changes in their default-features which would break users of did_url. We assume that the did_url crate won't be changed to fix this issue, in particular that this PR won't be merged, so we're pointing it out to you instead. A fix on your side would be to add form_urlencoded to your dependencies and pin it, i.e.:

form_urlencoded = { version = "=1.1.0" }

We recently released a similar fix for reference.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant