Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Added the ability to toggle the Carbon toolbar and adjust the margin #873

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

jer-k
Copy link
Contributor

@jer-k jer-k commented Sep 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
    • It appears there are no tests for the highlight-code module
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation content changes

Other information

I opened the issue on the https://github.com/deckgo/gatsby-remark-highlight-code project due in part to having no idea where this code actually lived. A big thank you to @peterpeterparker for directing me over here!

Issue Number: deckgo/gatsby-remark-highlight-code#21

For the example, I copied the <h1>Without line numbers</h1> example. The Github diff is being silly and showing my added changes above my <h1>Without dots</h1> when I actually added code below that. Also open to changing the content of the example if not as much is needed.

@peterpeterparker peterpeterparker added enhancement New feature or request highlight-code Highlight code web component labels Sep 17, 2020
@peterpeterparker peterpeterparker merged commit 7e66629 into deckgo:master Sep 17, 2020
@peterpeterparker peterpeterparker added this to the v2.4.0 milestone Sep 17, 2020
@peterpeterparker
Copy link
Contributor

Awesome @jer-k thank you for the PR 👍

P.S.: I'll release right now, I'll ping you in the other issue as soon as done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request highlight-code Highlight code web component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants