Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: use BigEndian order for Bolt to maintain correct ordering (closes #269) #270

Closed
wants to merge 1 commit into from

Conversation

PascalinDe
Copy link

@PascalinDe PascalinDe commented Sep 7, 2023

closes #269

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PascalinDe PascalinDe changed the title fix: use BigEndian order for Bolt to maintain correct ordering fix: use BigEndian order for Bolt to maintain correct ordering (closes #269) Sep 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ineiti
Copy link
Member

ineiti commented Sep 7, 2023

Just to make sure I looked at all binary.LittleEndian calls in Dela: can you confirm that the following line is NOT a problem, as it only uses the data, but not the key?

https://github.com/dedis/dela/blob/master/core/validation/simple/simple.go#L65

@PascalinDe
Copy link
Author

Just to make sure I looked at all binary.LittleEndian calls in Dela: can you confirm that the following line is NOT a problem, as it only uses the data, but not the key?

https://github.com/dedis/dela/blob/master/core/validation/simple/simple.go#L65

I'm not sure if that line is related to the key-value store in question, isn't it related to https://github.com/dedis/dela/blob/master/core/store/store.go?

the only places I found that handle the key of the Bolt store were in the same file as the change of this commit, and the key was only created, and used to retrieve data but not cast back to an uint64

@PascalinDe PascalinDe changed the title fix: use BigEndian order for Bolt to maintain correct ordering (closes #269) Draft: use BigEndian order for Bolt to maintain correct ordering (closes #269) Sep 7, 2023
@PascalinDe
Copy link
Author

moved the PR to draft, as I'm still testing though

@PascalinDe
Copy link
Author

tests look good so far (> 300 votes), but I had to test on https://github.com/dedis/dela/tree/fix-bbolt for d-voting, since d-voting is not working with the current head

@ineiti
Copy link
Member

ineiti commented Sep 24, 2024

Closing this for the new PRs

@ineiti ineiti closed this Sep 24, 2024
@ineiti ineiti deleted the 269 branch September 24, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robustness: DELA network breaks down after 256 rounds
4 participants