-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: use BigEndian order for Bolt to maintain correct ordering (closes #269) #270
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Just to make sure I looked at all https://github.com/dedis/dela/blob/master/core/validation/simple/simple.go#L65 |
I'm not sure if that line is related to the key-value store in question, isn't it related to https://github.com/dedis/dela/blob/master/core/store/store.go? the only places I found that handle the key of the Bolt store were in the same file as the change of this commit, and the key was only created, and used to retrieve data but not cast back to an uint64 |
moved the PR to draft, as I'm still testing though |
tests look good so far (> 300 votes), but I had to test on https://github.com/dedis/dela/tree/fix-bbolt for d-voting, since d-voting is not working with the current head |
Closing this for the new PRs |
closes #269