Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Format Strings are not executed #1901

Open
umesh-timalsina opened this issue Sep 9, 2020 · 4 comments
Open

Python Format Strings are not executed #1901

umesh-timalsina opened this issue Sep 9, 2020 · 4 comments
Labels

Comments

@umesh-timalsina
Copy link
Contributor

The following operation
image

Executes successfully. However the following fails

image

I suspect this is due to skulpt not recognizing format strings.

@umesh-timalsina
Copy link
Contributor Author

The error message is:

TypeError: Cannot read property 'getInputs' of undefined
    at GenerateJob.OperationOps.getInputs (/home/umesh/work/deepforge-dev/deepforge/src/common/plugin/Operation.js:32:36)
    at GenerateJob.createInputs (/home/umesh/work/deepforge-dev/deepforge/src/plugins/GenerateJob/GenerateJob.js:270:38)
    at GenerateJob.createOperationFiles (/home/umesh/work/deepforge-dev/deepforge/src/plugins/GenerateJob/GenerateJob.js:199:20)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async GenerateJob.main (/home/umesh/work/deepforge-dev/deepforge/src/plugins/GenerateJob/GenerateJob.js:96:23)

@brollb
Copy link
Contributor

brollb commented Sep 11, 2020

It might be worth considering switching skulpt out for a custom router providing the analysis for us as this would ensure we are using the correct python version (and wouldn't need to worry about discrepancies btwn skulpt and the python version used)...

@umesh-timalsina
Copy link
Contributor Author

After #1908 a router might not be necessary, as a language server is capable of pointing out errors in code in the text editor iteself. This can get rid of skulpt.

@brollb
Copy link
Contributor

brollb commented Sep 21, 2020

Unfortunately, skulpt is not actually being used in the error here to provide LSP-like feedback to the editor. It is being used to determine the operation interface so it can keep the implementation and the interface editor in sync. Since it is a pretty specific task, it's not able to be replaced by a language server :/

Examples of it can be found in the tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants