Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMEJSONNode and Typescript Refactor #30

Closed
umesh-timalsina opened this issue Apr 13, 2022 · 2 comments
Closed

GMEJSONNode and Typescript Refactor #30

umesh-timalsina opened this issue Apr 13, 2022 · 2 comments

Comments

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Apr 13, 2022

Based on a conversation with @brollb, we decided that it might be nice to add additional support with typescript for webgme-json-importer json format that adheres to the schema.

@umesh-timalsina umesh-timalsina changed the title Class GMEJSONNode and Typescript Refactor GMEJSONNode and Typescript Refactor Apr 13, 2022
@brollb
Copy link
Collaborator

brollb commented Apr 14, 2022

It is worth noting that using types should prevent internal bugs (or bugs when calling from typescript) but won't do any runtime checking. For that, we would need something like JSON schema (or using rust and wasm but that is a bigger jump and probably wouldn't be worth the bigger effort).

@brollb
Copy link
Collaborator

brollb commented Apr 14, 2022

We could also use something like TypeDoc potentially

@brollb brollb closed this as completed in 4659c8f Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants