Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node image to 20 #4888

Closed
niloc132 opened this issue Nov 28, 2023 · 0 comments · Fixed by #4907
Closed

Update node image to 20 #4888

niloc132 opened this issue Nov 28, 2023 · 0 comments · Fixed by #4907
Assignees
@niloc132
Labels
build feature request New feature or request javascript Pull requests that update Javascript code

Comments

@niloc132
Copy link
Member

We're using 14 now, which is EOL. 16 and 18 are "maintenance", and 20 just entered LTS, so we should probably move to 20.

This will require updating our proto:raw-js-openapi build, and the web:client-api:types as well. Both should have .npmrc and .nvmrc files added to specify expected node/npm versions.
@niloc132 niloc132 added feature request New feature or request build javascript Pull requests that update Javascript code labels Nov 28, 2023
@niloc132 niloc132 self-assigned this Nov 28, 2023
@niloc132 niloc132 mentioned this issue Nov 28, 2023
Merged
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Nov 29, 2023
@niloc132
Update node image, update builds to use it and enforce npm/node vers
b1bc4b3 
Fixes deephaven#4888
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Nov 30, 2023
@niloc132
Update node image, update builds to use it and enforce npm/node vers
8e475d0 
Fixes deephaven#4888
@niloc132 niloc132 mentioned this issue Dec 1, 2023
Merged
niloc132 added a commit that referenced this issue Feb 9, 2024
@niloc132
Deploy @deephaven/jsapi-types during release, provide tools for nig…
168ff34 
…htly builds (#4907)

Like other packages, the npmjs package for jsapi types will now get its
version assigned as it is built from gradle. Also reads properties from
gradle to specify --preid to npm (e.g. -PnpmPreid=nightly), to be given
a date stamp suffix.

Public job for CI will now deploy tagged versions to npmjs.

Fixes #4888
Fixes #5081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
build feature request New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
1 participant
@niloc132