Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerated JS API type necessary fixes #5081

Closed
5 tasks done
mattrunyon opened this issue Jan 29, 2024 · 0 comments · Fixed by #4907
Closed
5 tasks done

Autogenerated JS API type necessary fixes #5081

mattrunyon opened this issue Jan 29, 2024 · 0 comments · Fixed by #4907
Assignees
@niloc132
Labels
bug Something isn't working jsapi
Milestone
1. January 2024 (...

Comments

@mattrunyon
Copy link
Contributor

mattrunyon commented Jan 29, 2024 •
edited
Loading

Changes needed to work with my branch (https://github.com/mattrunyon/web-client-ui/tree/jsapi-types) updating web-client-ui to use the generated JS API types

  • Add "types": "dist/index.d.ts" to package.json
  • Remove (or change to something like >=16) Node engines from package.json
  • LayoutHints.frontColumns should be nullable (back/frozen/hidden are nullable)
  • IdeConnection is missing the HasEventHandling methods in the generated types
  • TableData and SubscriptionData should return Array<Row> (I know there's some Java generics issue, but even a non-generic version works for TS sake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
bug Something isn't working jsapi
Projects
None yet
Milestone
1. January 2024 (end of month)
2 participants
@niloc132 @mattrunyon