Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectCodec implementations should be tested with legacy files (to ensure that we don't break old files without noticing) #5767

Closed
rcaudy opened this issue Jul 12, 2024 · 0 comments · Fixed by #6207
Assignees
Labels
2023_unscheduled core Core development tasks feature request New feature or request parquet Related to the Parquet integration
Milestone

Comments

@rcaudy
Copy link
Member

rcaudy commented Jul 12, 2024

A number of our ObjectCodec implementations are not currently used by default (for example, BigDecimalCodec). We typically have round-trip tests, verifying that they can still write and re-read data correctly. We should also have Parquet-based tests wherein we verify that we can still consume old files correctly, in order to catch cases when we inadvertently change the interpretation of previously-written data and prevent us from breaking support for user files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023_unscheduled core Core development tasks feature request New feature or request parquet Related to the Parquet integration
Projects
None yet
3 participants