feat(cpp-client): Generate protos for C++ as part of the build #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
reviewed
Sep 26, 2024
jcferretti
changed the title
jcferretti
changed the title
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
kosak
previously approved these changes
Sep 26, 2024
kosak
approved these changes
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the conversation with Colin around the last protobuf change for C++ we discussed the need to move away in the C++ build from storing the generated protos in git and instead generate as part of the build itself. We actually need the ability to do that now with Excel and its dependency on a Windows build, because on Windows we depend on vcpkg and the latest version of protobuf that vcpkg makes available, which lags behind in ways that are out of our control regarding the protobuf released versions. This PR makes proto generation part of the build and its output a build artifact, and removes the gen protos from git.