Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit restoring an existing session after browser refresh #1141

Closed
niloc132 opened this issue Mar 7, 2023 · 0 comments · Fixed by #1244
Closed

Permit restoring an existing session after browser refresh #1141

niloc132 opened this issue Mar 7, 2023 · 0 comments · Fixed by #1244
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@niloc132
Copy link
Member

niloc132 commented Mar 7, 2023

As a user who sometimes encounters errors in the Web UI, I occasionally refresh the page and expect my existing session to remain active.

This is more of a concern now with anonymous access being disabled in an upcoming release - rather than authenticate again, the dh.CoreClient fires a EVENT_REFRESH_TOKEN_UPDATED event with a token that can be stored, and for a limited time, used to reconnect to the same session. That token can either be passed to dh.CoreClient.relogin() (matching DHE's behavior), or the string in its bytes field passed to login(), with type set to Bearer.

@niloc132 niloc132 added enhancement New feature or request triage Issue requires triage labels Mar 7, 2023
@vbabich vbabich added this to the March 2023 milestone Mar 8, 2023
@vbabich vbabich removed the triage Issue requires triage label Mar 8, 2023
@mofojed mofojed modified the milestones: March 2023, April 2023 Apr 3, 2023
@mofojed mofojed self-assigned this Apr 24, 2023
@mofojed mofojed linked a pull request May 4, 2023 that will close this issue
@mofojed mofojed closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants