Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-12163 - Column grouping sidebar test failure fixes #1142

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

mattrunyon
Copy link
Collaborator

  • Does not select new groups when searching
  • Shows validation error if you create a new group and blur without typing anything into the name field
  • Prevents Firefox on Mac from getting stuck in a bad state where color pickers can't be opened. The bug occurs when multiple color inputs are on the screen at once and the user clicks between the without closing the previous picker

@mattrunyon mattrunyon requested a review from mofojed March 7, 2023 23:48
@mattrunyon mattrunyon self-assigned this Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1142 (245eb59) into main (7448a88) will increase coverage by 0.01%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   43.41%   43.43%   +0.01%     
==========================================
  Files         435      435              
  Lines       32688    32701      +13     
  Branches     8244     8249       +5     
==========================================
+ Hits        14193    14205      +12     
- Misses      18446    18447       +1     
  Partials       49       49              
Flag Coverage Δ
unit 43.43% <96.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ility-ordering-builder/VisibilityOrderingGroup.tsx 98.59% <95.45%> (-1.41%) ⬇️
...ity-ordering-builder/VisibilityOrderingBuilder.tsx 100.00% <100.00%> (ø)
packages/grid/src/GridRenderer.ts 50.58% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mofojed mofojed self-requested a review March 8, 2023 20:02
@mattrunyon mattrunyon merged commit a55308d into deephaven:main Mar 8, 2023
@mattrunyon mattrunyon deleted the dh-12163-fix branch March 8, 2023 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants