fix: Fix column data appearing incorrectly when multiplier null #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue with Formatting values - Enterprise uses `multiplier: null` for the default settings, but in Community we only expected `undefined` or `number`. - Just handle when `multiplier` is `null` as well - Fixes deephaven#1193 - Tested by manually adding a formatter with `multiplier: null` in LocalWorkspaceStorage, e.g.: ``` formatter: [ { columnType: 'decimal', columnName: 'Bid', format: { label: '', type: 'type-global', formatString: '###,##0.00###', multiplier: null, }, }, ], ```
vbabich
previously approved these changes
Apr 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
- Coverage 44.20% 44.20% -0.01%
==========================================
Files 448 448
Lines 33430 33437 +7
Branches 8401 8404 +3
==========================================
+ Hits 14778 14781 +3
- Misses 18602 18606 +4
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vbabich
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiplier: nullfor the default settings, but in Community we only expectedundefinedornumber.multiplierisnullas wellmultiplier: nullin LocalWorkspaceStorage, e.g.: