Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@deephaven/components): DH-14630 Custom React Spectrum Provider #1211

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Apr 6, 2023

Supports Enterprise DH-14630

Custom React Spectrum Provider component.

resolves #1210

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1211 (2f3cb77) into main (85ce600) will increase coverage by 0.79%.
The diff coverage is 100.00%.

❗ Current head 2f3cb77 differs from pull request most recent head 45ab830. Consider uploading reports for the commit 45ab830 to get more accurate results

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   44.26%   45.05%   +0.79%     
==========================================
  Files         450      451       +1     
  Lines       33480    33490      +10     
  Branches     8420     8427       +7     
==========================================
+ Hits        14820    15090     +270     
+ Misses      18610    18350     -260     
  Partials       50       50              
Flag Coverage Δ
unit 45.05% <100.00%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/SpectrumUtils.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bmingles bmingles force-pushed the 1210-react-spectrum-provider branch from 57cef03 to f2d0596 Compare April 6, 2023 19:38
@bmingles bmingles marked this pull request as ready for review April 6, 2023 20:20
@bmingles bmingles requested a review from mofojed April 6, 2023 20:20
packages/components/src/SpectrumProvider.tsx Outdated Show resolved Hide resolved
packages/components/package.json Outdated Show resolved Hide resolved
@bmingles bmingles force-pushed the 1210-react-spectrum-provider branch from d708121 to aaa0b4d Compare April 11, 2023 14:58
@bmingles bmingles requested a review from mofojed April 11, 2023 20:25
@bmingles bmingles force-pushed the 1210-react-spectrum-provider branch from 8d41a16 to 7da9471 Compare April 12, 2023 19:01
@bmingles bmingles requested a review from mattrunyon April 12, 2023 19:03
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the breaking change to be 3rd person and specify which package needs to add react spectrum in the comment.

Can also do feat(@deephaven/components) in the title I believe to indicate the scope of the change

packages/components/src/SpectrumUtils.test.ts Show resolved Hide resolved
packages/components/src/SpectrumUtils.ts Show resolved Hide resolved
@bmingles bmingles changed the title feat: Custom React Spectrum Provider feat(@deephaven/components): Custom React Spectrum Provider Apr 13, 2023
@bmingles bmingles requested a review from mattrunyon April 13, 2023 14:00
mofojed
mofojed previously approved these changes Apr 14, 2023
packages/components/src/SpectrumProvider.tsx Outdated Show resolved Hide resolved
packages/components/src/SpectrumUtils.ts Outdated Show resolved Hide resolved
@bmingles bmingles requested a review from mofojed April 17, 2023 16:13
@bmingles bmingles merged commit 609c57e into deephaven:main Apr 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
@bmingles bmingles deleted the 1210-react-spectrum-provider branch April 18, 2023 22:52
@bmingles bmingles changed the title feat(@deephaven/components): Custom React Spectrum Provider feat(@deephaven/components): DH-14630 Custom React Spectrum Provider Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DH-14581: React Spectrum Theme Provider
3 participants