Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve plugin load error handling #1214

Merged
merged 9 commits into from
Apr 14, 2023

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Apr 10, 2023

Loads plugins individually instead of failing to register if any plugin fails to load. Previously if any plugin failed to load for any reason then no plugins were registered.

Does some validation on if the manifest file exists and the structure of it so that the errors are more descriptive. Does not throw a 2nd error about Unexpected token < if there is no manifest file

@mattrunyon mattrunyon requested a review from mofojed April 10, 2023 18:34
@mattrunyon mattrunyon self-assigned this Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #1214 (98e83e1) into main (59d3df4) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   44.20%   44.25%   +0.04%     
==========================================
  Files         448      450       +2     
  Lines       33437    33488      +51     
  Branches     8404     8427      +23     
==========================================
+ Hits        14781    14820      +39     
- Misses      18606    18618      +12     
  Partials       50       50              
Flag Coverage Δ
unit 44.25% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/main/AppInit.tsx 0.00% <0.00%> (ø)
packages/code-studio/src/plugins/PluginUtils.tsx 3.84% <0.00%> (+0.62%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/code-studio/src/plugins/PluginUtils.tsx Outdated Show resolved Hide resolved
packages/code-studio/src/plugins/PluginUtils.tsx Outdated Show resolved Hide resolved
@mattrunyon mattrunyon requested a review from mofojed April 13, 2023 20:19
@mattrunyon mattrunyon requested a review from mofojed April 14, 2023 16:09
packages/code-studio/vite.config.ts Outdated Show resolved Hide resolved
@mattrunyon mattrunyon requested a review from mofojed April 14, 2023 16:15
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend throwing an error instead of a string

packages/code-studio/src/plugins/PluginUtils.tsx Outdated Show resolved Hide resolved
@mattrunyon mattrunyon requested a review from mofojed April 14, 2023 16:18
@mattrunyon mattrunyon merged commit 8ac7dc8 into deephaven:main Apr 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
@mattrunyon mattrunyon deleted the improve-plugin-loading branch June 23, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants