-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve plugin load error handling #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 44.20% 44.25% +0.04%
==========================================
Files 448 450 +2
Lines 33437 33488 +51
Branches 8404 8427 +23
==========================================
+ Hits 14781 14820 +39
- Misses 18606 18618 +12
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend throwing an error instead of a string
Loads plugins individually instead of failing to register if any plugin fails to load. Previously if any plugin failed to load for any reason then no plugins were registered.
Does some validation on if the manifest file exists and the structure of it so that the errors are more descriptive. Does not throw a 2nd error about
Unexpected token <
if there is no manifest file