Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new icons and added composition example to styleguide #1294

Merged
merged 1 commit into from
May 15, 2023

Conversation

dsmmcken
Copy link
Contributor

Added dhOrganizationAdd icon for ACL editor and dhAddSmall for composition if needed somewhere else. Also added composition example to styleguide.

@dsmmcken dsmmcken self-assigned this May 12, 2023
@dsmmcken dsmmcken requested a review from bmingles May 12, 2023 20:28
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1294 (0db68bc) into main (29ed459) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   45.49%   45.48%   -0.01%     
==========================================
  Files         504      504              
  Lines       34826    34833       +7     
  Branches     8688     8688              
==========================================
+ Hits        15844    15845       +1     
- Misses      18931    18937       +6     
  Partials       51       51              
Flag Coverage Δ
unit 45.48% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/styleguide/Icons.tsx 55.17% <14.28%> (-5.62%) ⬇️

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

I did notice that our icon search seems to expect a dash cased string instead of camelCase. I don't think this is related to this change at all, so approving.

@dsmmcken dsmmcken merged commit 97c7ead into main May 15, 2023
@dsmmcken dsmmcken deleted the dmckenzie_icons branch May 15, 2023 20:09
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants