-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data bar render from API #1415
feat: data bar render from API #1415
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 46.42% 46.42%
=======================================
Files 558 556 -2
Lines 35706 35727 +21
Branches 8917 8921 +4
=======================================
+ Hits 16576 16586 +10
- Misses 19080 19091 +11
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The prettier check is still failing after fixing the few files mentioned in the summary. So I fixed all of them but now the PR size is significantly larger. @mofojed this PR should probably go in after @bmingles PR where he makes all the style changes across community Not sure if I can just rebase off main when that happens or if I need to revert the prettier commits I have in this branch |
@ethanalvizo This should be addressed once PR #1430 merges |
No specific ticket to close. Just alters the front-end to allow the new data from JSON API to be parsed and turned into a data bar
Works in tandem with this deephaven/deephaven-core#4181 from deephaven-core
Demo Code:
Expected Output: