Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change display of rollup key columns from null to empty string #1563

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

georgecwan
Copy link
Contributor

@georgecwan georgecwan commented Oct 10, 2023

Testing Instructions:

  1. Run:
from deephaven import empty_table, time_table

size = 100
scale = 1000

random_values_with_null_NaN = empty_table(size).update([
    "MyString=(i%11==0? null : `a`+(int)(scale*(Math.random()*2-1)))"
])
  1. Add the string and char columns and any other arbitrary columns as rollup columns in any order
  2. The key column should only show null if it actually represents a null value in the column

@georgecwan georgecwan requested a review from mofojed October 10, 2023 17:24
@georgecwan georgecwan self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (5592627) 46.43% compared to head (eabc635) 46.46%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1563      +/-   ##
==========================================
+ Coverage   46.43%   46.46%   +0.03%     
==========================================
  Files         564      571       +7     
  Lines       35741    36020     +279     
  Branches     8928     9017      +89     
==========================================
+ Hits        16597    16738     +141     
- Misses      19094    19230     +136     
- Partials       50       52       +2     
Flag Coverage Δ
unit 46.46% <35.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/iris-grid/src/PartitionSelectorSearch.tsx 69.75% <81.25%> (-4.11%) ⬇️
...ckages/iris-grid/src/IrisGridPartitionSelector.tsx 34.48% <22.22%> (-0.97%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 26.84% <0.00%> (-0.13%) ⬇️
packages/iris-grid/src/IrisGridTreeTableModel.ts 0.00% <0.00%> (ø)

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgecwan georgecwan requested a review from mofojed October 11, 2023 16:42
mofojed
mofojed previously approved these changes Oct 12, 2023
packages/iris-grid/src/IrisGridTreeTableModel.ts Outdated Show resolved Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@georgecwan georgecwan requested a review from mofojed October 12, 2023 15:11
@mofojed mofojed merged commit 327bcb6 into deephaven:main Oct 13, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@georgecwan georgecwan deleted the 1483-rollup-null-key branch October 13, 2023 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup grouping columns shouldn't show as 'null'
2 participants