Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conventionalcommits changelog preset #1566

Closed
mofojed opened this issue Oct 10, 2023 · 1 comment
Closed

Use conventionalcommits changelog preset #1566

mofojed opened this issue Oct 10, 2023 · 1 comment
Labels
bug Something isn't working triage Issue requires triage

Comments

@mofojed
Copy link
Member

mofojed commented Oct 10, 2023

Apparently lerna uses the angular changelog preset by default. We should be using the conventionalcommits preset, so that we can add an exclamation mark after type. Currently you cannot put an exclamation mark after the type (as noted in our CONTRIBUTING guide) or things will blow up when you try to version it. According to this lerna issue, it's because we're using the wrong preset: lerna/lerna#2668 (comment)

However I tried to create a PR for doing exactly that: #1565

But it just hangs on the versioning step. Logging this ticket to record the information, and then I'm going to forget about it for now.
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Oct 10, 2023
@mofojed mofojed mentioned this issue Oct 10, 2023
Merged
@vbabich
Copy link
Collaborator

vbabich commented Oct 17, 2023

Won't fix

@vbabich vbabich closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbabich @mofojed