Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tab in console input triggers autocomplete instead of indent #1591

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mattrunyon
Copy link
Collaborator

In the console, pressing the Tab key previously brought up the autocomplete prompt. Now it will insert a tab's worth of spaces instead.

Can still trigger autocomplete by using Ctrl+Space

@mattrunyon mattrunyon requested a review from mofojed October 20, 2023 21:37
@mattrunyon mattrunyon self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f440a38) 46.65% compared to head (9a7bc83) 46.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1591   +/-   ##
=======================================
  Coverage   46.65%   46.66%           
=======================================
  Files         575      575           
  Lines       36189    36182    -7     
  Branches     9063     9061    -2     
=======================================
  Hits        16883    16883           
+ Misses      19254    19247    -7     
  Partials       52       52           
Flag Coverage Δ
unit 46.66% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/console/src/ConsoleInput.tsx 70.04% <0.00%> (+2.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit fbe1e70 into deephaven:main Oct 24, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@mattrunyon mattrunyon deleted the repl-tab-fix branch June 23, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants