Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot #1617

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Nov 2, 2023

Reset isStuckToBottom and isStuckToRight in dropLayoutMinorChange.

The flags are still stored in the shared layout, but don't trigger the sharing dot.

Testing:

  • Open a new dashboard, add a table with more rows than fits on the screen
  • Share the dashboard layout with the table scrolled up, isStuckToBottom is false
  • Scroll the table to the bottom, confirm the Sharing dot doesn't appear even though the isStuckToBottom flag is now set to true
  • Click on the Sharing button, confirm the dialog shows the "Share updated state" message allowing to share the new isStuckToBottom state
  • Scroll the table up a few rows to get it un-stuck, confirm the blue dot still doesn't show up. Open the Sharing dialog, confirm the "Share update state" message disappeared since the current isStuckToBottom state matches the shared state
  • Scroll the table all the way down, discard the layout changes via the Sharing dialog, don't close the dialog. Confirm the table after discard is scrolled up (initial shared isStuckToBottom: false state restored).

@vbabich vbabich self-assigned this Nov 2, 2023
@vbabich vbabich requested a review from mofojed November 2, 2023 19:34
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5977389) 46.72% compared to head (8e46304) 46.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   46.72%   46.71%   -0.01%     
==========================================
  Files         583      583              
  Lines       36312    36308       -4     
  Branches     9094     9094              
==========================================
- Hits        16965    16961       -4     
  Misses      19295    19295              
  Partials       52       52              
Flag Coverage Δ
unit 46.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/dashboard/src/layout/LayoutUtils.ts 13.86% <0.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich merged commit 3d4499b into deephaven:main Nov 2, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants