Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat: forward and back buttons for organize column search #1640

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

dsmmcken
Copy link
Contributor

This reverts commit 75cf184.

Auto-merge was to eager, I only approved for functionality not code reviewed.

@dsmmcken dsmmcken changed the title Revert "feat: forward and back buttons for organize column search (#1… revert: feat: forward and back buttons for organize column search Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (75cf184) 46.62% compared to head (1a4cb88) 46.62%.

Files Patch % Lines
packages/components/src/SearchInput.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
- Coverage   46.62%   46.62%   -0.01%     
==========================================
  Files         592      592              
  Lines       36509    36430      -79     
  Branches     9148     9124      -24     
==========================================
- Hits        17023    16984      -39     
+ Misses      19434    19394      -40     
  Partials       52       52              
Flag Coverage Δ
unit 46.62% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken merged commit 737d1aa into main Nov 14, 2023
5 of 6 checks passed
@dsmmcken dsmmcken deleted the revert-1620-1529-organize-col-search-button branch November 14, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants