Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Theming - Inline svgs #1651

Merged
merged 46 commits into from
Nov 30, 2023
Merged

Conversation

bmingles
Copy link
Contributor

No description provided.

@dsmmcken
Copy link
Contributor

dsmmcken commented Nov 17, 2023

would I then have to specify an INLINE_THEME.TS file to replace the icons if I, as a third party theme write was trying to create one?

I imagined it would have just been like variable as part of theme:

--icon-whatever: url("svg path blah blah blah fill="var(--some-color)"...")

and then before you insert the variables/on theme change you resolve it to the actual color

@bmingles
Copy link
Contributor Author

would I then have to specify an INLINE_THEME.TS file to replace the icons if I, as a third party theme write was trying to create one?

I imagined it would have just been like variable as part of theme:

--icon-whatever: url("svg path blah blah blah fill="var(--some-color)"...")

and then before you insert the variables/on theme change you resolve it to the actual color

@dsmmcken You can just define the svg css var in the theme .css files. Since it gets loaded after the inlinesvgs, it will take precedence

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (c0cc966) 46.62% compared to head (13663d9) 46.66%.

❗ Current head 13663d9 differs from pull request most recent head 5e7846b. Consider uploading reports for the commit 5e7846b to get more accurate results

Files Patch % Lines
packages/code-studio/src/styleguide/colorUtils.ts 27.90% 31 Missing ⚠️
...ackages/code-studio/src/styleguide/ThemeColors.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   46.62%   46.66%   +0.04%     
==========================================
  Files         597      599       +2     
  Lines       36620    36660      +40     
  Branches     9172     9184      +12     
==========================================
+ Hits        17073    17107      +34     
- Misses      19495    19501       +6     
  Partials       52       52              
Flag Coverage Δ
unit 46.66% <59.03%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles marked this pull request as ready for review November 22, 2023 15:57
@bmingles bmingles requested a review from mofojed November 22, 2023 15:57
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of cleanup. Looks good overall.

@bmingles bmingles requested a review from mofojed November 30, 2023 17:30
@bmingles bmingles merged commit 1e40d3e into deephaven:main Nov 30, 2023
4 checks passed
@bmingles bmingles deleted the 1634-inline-svgs branch November 30, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants