-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Theme Selector #1661
feat: Theme Selector #1661
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
- Coverage 46.65% 46.63% -0.02%
==========================================
Files 599 602 +3
Lines 36671 36718 +47
Branches 9192 9204 +12
==========================================
+ Hits 17109 17124 +15
- Misses 19510 19542 +32
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor cleanup, looks good overall
const themePluginEntries = [...pluginMap.entries()].filter( | ||
(entry): entry is [string, ThemePlugin] => isThemePlugin(entry[1]) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can shorten it, you're not using the keys at all:
const themePluginEntries = [...pluginMap.entries()].filter( | |
(entry): entry is [string, ThemePlugin] => isThemePlugin(entry[1]) | |
); | |
const themePluginEntries = [...pluginMap.values()].filter(isThemePlugin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys aren't used here, but they do get consumed in the next block when themePluginEntries
is iterated, so the key + value needs to be present
a097d86
to
9f4f3aa
Compare
resolves #1660