Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Made selector return types generic #1688

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: Made selector return types generic #1688

merged 2 commits into from
Dec 12, 2023

Conversation

bmingles
Copy link
Contributor

fixes #1687

@bmingles bmingles requested a review from mofojed December 12, 2023 15:13
mofojed
mofojed approved these changes Dec 12, 2023
View reviewed changes
packages/utils/src/TypeUtils.ts
* than `Required` because it will preserve optional properties on the original
* target type.
*/
export type UndoPartial<T> = T extends Partial<infer U> ? U : never;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh neat

@bmingles bmingles merged commit b2972f0 into deephaven:main Dec 12, 2023
4 checks passed
@bmingles bmingles deleted the 1687-selector-types branch December 12, 2023 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redux selector return types should be generic
2 participants
@bmingles @mofojed