-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bind this to utils that moved from static to non-static with js api de-globalization #1795
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 46.05% 46.04% -0.01%
==========================================
Files 628 628
Lines 37784 37781 -3
Branches 9516 9516
==========================================
- Hits 17400 17397 -3
Misses 20330 20330
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -611,6 +611,7 @@ export class IrisGrid extends Component<IrisGridProps, IrisGridState> { | |||
this.handleGotoValueSelectedFilterChanged.bind(this); | |||
this.handleGotoValueChanged = this.handleGotoValueChanged.bind(this); | |||
this.handleGotoValueSubmitted = this.handleGotoValueSubmitted.bind(this); | |||
this.makeQuickFilter = this.makeQuickFilter.bind(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we call this makeQuickFilter
with the wrong context somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I'm aware of, it was just something that was a static method before de-globalization and is no longer static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I couldn't find it either. Probably not necessary to bind then, but doesn't matter since we are doing bindAll in other places.
I noticed this issue while investigating deephaven/deephaven-plugins#179 and switching a param of
(v) => this.chartUtils.unwrapValue(v)
to justthis.chartUtils.unwrapValue
Looked through the other de-globalization PRs and added
bindAllMethods
to any classes where there were some static methods moved to non-static so that they can be used this way