Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide expand all when not available #1854

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: hide expand all when not available #1854

merged 1 commit into from
Mar 8, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Mar 6, 2024

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.07%. Comparing base (162f879) to head (3218b47).
Report is 4 commits behind head on main.

Files Patch % Lines
packages/iris-grid/src/IrisGrid.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
+ Coverage   46.03%   46.07%   +0.03%     
==========================================
  Files         635      635              
  Lines       37935    38017      +82     
  Branches     9563     9611      +48     
==========================================
+ Hits        17465    17517      +52     
- Misses      20416    20447      +31     
+ Partials       54       53       -1     
Flag Coverage Δ
unit 46.07% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 marked this pull request as ready for review March 6, 2024 19:48
@wusteven815 wusteven815 requested a review from mofojed March 6, 2024 19:48
@wusteven815 wusteven815 merged commit aa34ace into deephaven:main Mar 8, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
@wusteven815 wusteven815 deleted the hide-expand-all branch March 8, 2024 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DH-16532: Hide the "Expand row and all children" shortcut if the expandAll function isn't available
2 participants