Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export spectrum useStyleProp util #1916

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Apr 3, 2024

useStyleProp takes common spectrum style props and resolves them to values. In my case I need the resolved version of a dimensionValue ("size-100") as var(--XXX), and things like paddingY resolved as paddingTop, paddingBottom for use externally in dh.ui.

@dsmmcken dsmmcken requested a review from bmingles April 3, 2024 19:57
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.26%. Comparing base (ffedd7a) to head (03c4b82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   46.26%   46.26%           
=======================================
  Files         646      646           
  Lines       38252    38252           
  Branches     9673     9673           
=======================================
  Hits        17697    17697           
  Misses      20502    20502           
  Partials       53       53           
Flag Coverage Δ
unit 46.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

useStyleProps takes the common spectrum style props and resolves them to values. In my case I need the resolved version of a dimensionValue ("size-100") as var(--XXX), and things like paddingY resolved as paddingTop, paddingBottom.
@dsmmcken dsmmcken force-pushed the dmckenzie_useStyleProps branch from c9afe84 to 03c4b82 Compare April 4, 2024 16:46
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsmmcken dsmmcken enabled auto-merge (squash) April 4, 2024 16:49
@dsmmcken dsmmcken merged commit aafa14b into main Apr 4, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_useStyleProps branch April 4, 2024 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants