-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: context menu reopen for stack only #1932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wusteven815
commented
Apr 12, 2024
•
edited
Loading
edited
- Adds Panel context menu should have option to reopen from its stack #1931
- Add new context menu option for panels
- Give IDs to stacks and helper function to get stacks by ID
- Add ability to open component to specific stack
- Fix unit tests related to IDs and layouts, added E2E tests
mofojed
previously requested changes
Apr 16, 2024
packages/dashboard-core-plugins/src/panels/PanelContextMenu.tsx
Outdated
Show resolved
Hide resolved
mofojed
reviewed
Apr 16, 2024
packages/dashboard-core-plugins/src/panels/PanelContextMenu.tsx
Outdated
Show resolved
Hide resolved
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
mofojed
previously requested changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small cleanup, looks great!
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.