Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: datetime tooltip to show full value #2286

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Nov 8, 2024

@wusteven815 wusteven815 self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 9.33333% with 68 lines in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (5ebc195) to head (a8ca90c).

Files with missing lines Patch % Lines
...id/src/mousehandlers/IrisGridTokenMouseHandler.tsx 8.47% 54 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 25.00% 6 Missing ⚠️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 0.00% 5 Missing ⚠️
packages/iris-grid/src/IrisGridModel.ts 0.00% 2 Missing ⚠️
...s/grid/src/mouse-handlers/GridTokenMouseHandler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
+ Coverage   46.60%   46.61%   +0.01%     
==========================================
  Files         704      704              
  Lines       38963    38956       -7     
  Branches     9914     9730     -184     
==========================================
+ Hits        18158    18160       +2     
+ Misses      20794    20785       -9     
  Partials       11       11              
Flag Coverage Δ
unit 46.61% <9.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/grid/src/mouse-handlers/index.ts Outdated Show resolved Hide resolved
packages/grid/src/GridModel.ts Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
@wusteven815 wusteven815 marked this pull request as ready for review November 15, 2024 15:11
@wusteven815 wusteven815 requested review from a team and bmingles and removed request for a team November 15, 2024 15:11
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion to simplify nested if / else structure

@wusteven815 wusteven815 requested a review from bmingles December 4, 2024 15:18
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wusteven815 wusteven815 merged commit 238f611 into deephaven:main Dec 5, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full values of DateTimes should be more accessible
3 participants