-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: datetime tooltip to show full value #2286
Conversation
wusteven815
commented
Nov 8, 2024
•
edited
Loading
edited
- Closes Full values of DateTimes should be more accessible #614
- Adds tooltip for datetime cells showing full value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
+ Coverage 46.60% 46.61% +0.01%
==========================================
Files 704 704
Lines 38963 38956 -7
Branches 9914 9730 -184
==========================================
+ Hits 18158 18160 +2
+ Misses 20794 20785 -9
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/iris-grid/src/mousehandlers/IrisGridTooltipMouseHandler.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion to simplify nested if / else structure
packages/iris-grid/src/mousehandlers/IrisGridTokenMouseHandler.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM