Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export Spectrum Toast from Components Package #2294

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

dgodinez-dh
Copy link
Contributor

Closes #2293
This is needed to implement the deephaven.ui toast component.

@dgodinez-dh dgodinez-dh requested review from a team and vbabich and removed request for a team November 14, 2024 15:40
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (cb1f11f) to head (63ee5b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/code-studio/src/styleguide/Toast.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   46.60%   46.60%   -0.01%     
==========================================
  Files         703      704       +1     
  Lines       38957    38963       +6     
  Branches     9914     9914              
==========================================
+ Hits        18156    18158       +2     
+ Misses      20790    20751      -39     
- Partials       11       54      +43     
Flag Coverage Δ
unit 46.60% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vbabich
vbabich previously approved these changes Nov 14, 2024
@dgodinez-dh dgodinez-dh requested a review from vbabich November 14, 2024 20:52
@dgodinez-dh dgodinez-dh merged commit a0961ad into deephaven:main Nov 14, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Spectrum Toast
2 participants