Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattergl plotting not working correctly in styleguide #304

Closed
mofojed opened this issue Nov 19, 2021 · 3 comments
Closed

scattergl plotting not working correctly in styleguide #304

mofojed opened this issue Nov 19, 2021 · 3 comments
Labels
bug Something isn't working web-client-ui
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Nov 19, 2021

Description
The trendline/line plots in the styleguide are not appearing correctly (anything scattergl). It appears they still work in the actual application.

Steps to reproduce

  1. Go to http://localhost:4000/styleguide
  2. Scroll down to the plot

Expected results
2. Plot appears correctly with trend lines

Actual results
2. Plot only shows the area graph

Additional details and attachments
image

There is an error in the logs:

index.js:1 Error: (regl) Error compiling fragment shader, http://localhost:4000/static/js/vendors~main.chunk.js:426274:22
    at Function.raise (bundle.js:987)
    at Function.checkShaderError [as shaderError] (bundle.js:987)
    at Object.getShader [as shader] (bundle.js:987)
    at bundle.js:987
    at Function.checkOptional [as optional] (bundle.js:987)
    at parseShader (bundle.js:987)
    at parseProgram (bundle.js:987)
    at parseArguments (bundle.js:987)
    at Object.compileCommand [as compile] (bundle.js:987)
    at compileProcedure (bundle.js:987)
    at Function.push.../../node_modules/regl-line2d/index.js.Line2D.createShaders (index.js:126)
    at new Line2D (index.js:47)
    at Line2D (index.js:23)
    at Object.plot (plot.js:67)
    at plotOne (index.js:259)
    at Object.push.../../node_modules/plotly.js/src/plots/cartesian/index.js.exports.plot (index.js:182)
    at push.../../node_modules/plotly.js/src/plot_api/subroutines.js.exports.drawData (subroutines.js:585)
    at Object.push.../../node_modules/plotly.js/src/lib/index.js.lib.syncOrAsync (index.js:455)
    at Object._doPlot (plot_api.js:389)
    at Object.newPlot (plot_api.js:566)
    at Object.react (plot_api.js:2594)
    at factory.js:82

Running a scattergl command in the IDE works fine:

from deephaven.TableTools import emptyTable
from deephaven.Plot import plot
t = emptyTable(100).update("x=i", "y=Math.random()*(i*100)")
p = plot("Plot", t, "x", "y").plotStyle("SCATTER").show()

If applicable, add any additional screenshots, logs, or other attachments to help explain your problem.

Versions

  • Deephaven: ...
  • OS: ...
  • Browser: ...
  • Docker: ...
@mofojed mofojed added bug Something isn't working triage Issue requires triage and removed triage Issue requires triage labels Nov 19, 2021
@mofojed mofojed added this to the Backlog milestone Nov 24, 2021
@bmingles
Copy link
Contributor

bmingles commented Nov 2, 2023

@mofojed I don't see the original error message in the description. I'm seeing a slightly different set of WebGL warnings

image

Also, the given scattergl command doesn't seem to work for me. Does it still work for you?

@bmingles
Copy link
Contributor

bmingles commented Nov 2, 2023

This one seems to illustrate the issue

from deephaven.plot.figure import Figure
from deephaven.plot import PlotStyle
from deephaven.plot import Color, Colors
from deephaven.plot import font_family_names, Font, FontStyle, Shape

source=empty_table(100).update(["x=i", "y=Math.sin(i)", "z=Math.cos(i)"])

plot_xy_scatter = Figure()\
    .plot_xy(series_name="Speed", t=source, x="x", y="y")\
    .axes(plot_style=PlotStyle.SCATTER)\
    .x_twin()\
    .plot_xy(series_name="Distance", t=source, x="x", y="z")\
    .axes(plot_style=PlotStyle.SCATTER)\
    .show()

@bmingles
Copy link
Contributor

bmingles commented Nov 2, 2023

I switched the 'scattergl' types to 'scatter' in the MockChartModel for the styleguide in #1608 . @mofojed I'll leave it up to you whether this needs more digging, but the styleguide should be working once that PR merges.

@dsmmcken dsmmcken closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web-client-ui
Projects
None yet
Development

No branches or pull requests

3 participants