[tokenizers] Fixes memory leak when there is overflowing tokens #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up all overflow encodings. If withOverflowingTokens was false no Encodings where generated leaving jni Encoding handles that would not be properly deleted. This introduces a new native method where you can inquire about number of overflow tokens without using any jni resources. And you will now only call TokenizersLibrary.LIB.getOverflowing(encoding) if withOverflowingTokens is true.
|
@frankfliu This PR suggests a solution to issue #3316 |
frankfliu
changed the title
frankfliu
approved these changes
Jul 10, 2024
baldersheim
deleted the
baldersheim/prevent-leaking-memory-when-withOverflowingTokens-is-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3316
If you call TokenizersLibrary.LIB.getOverflowing you must also clean up all overflow encodings.
If withOverflowingTokens was false no Encodings where generated leaving jni Encoding handles that would not be properly deleted.
This introduces a new native method where you can inquire about number of overflow tokens without using any jni resources. And you will now only call TokenizersLibrary.LIB.getOverflowing(encoding) if withOverflowingTokens is true.
Description
Brief description of what this PR is about