Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install farm-haystack[all-gpu] installs faiss-cpu, breaking FAISS #3218

Closed
1 task done
ZanSara opened this issue Sep 15, 2022 · 0 comments · Fixed by #3669
Closed
1 task done

pip install farm-haystack[all-gpu] installs faiss-cpu, breaking FAISS #3218

ZanSara opened this issue Sep 15, 2022 · 0 comments · Fixed by #3669
Assignees
Labels
Contributions wanted! Looking for external contributions P1 High priority, add to the next sprint topic:dependencies topic:faiss topic:speed type:bug Something isn't working

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Sep 15, 2022

Describe the bug

  • Installing Haystack with all GPU dependencies with pip install farm-haystack[all-gpu] will install also faiss-cpu, which does not play well with faiss-gpu. This should not happen.
  • If the two are installed together, there seems to be a difficulty in using faiss-gpu: for example, faiss.get_num_gpus() returns 0.

Investigation results

Action to take

To Reproduce

  • In a fresh Python env: pip install farm-haystack[all-gpu]
    • Note: this issue does not happen when doing pip install farm-haystack[faiss-gpu]

Error message

> pip freeze | grep faiss
faiss-cpu==1.7.2
faiss-gpu==1.7.2

Expected behavior

> pip freeze | grep faiss
faiss-gpu==1.7.2

Additional context

FAQ Check

@masci masci added the P1 High priority, add to the next sprint label Nov 24, 2022
@ZanSara ZanSara self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions wanted! Looking for external contributions P1 High priority, add to the next sprint topic:dependencies topic:faiss topic:speed type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants