fix(ReactComponentLibrary): Do not drill isInvalid prop to DOM nodes

Royal-Navy · Nov 16, 2020 · 7b2d067 · 7b2d067
1 parent 84614e7
commit 7b2d067
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/packages/react-component-library/src/components/Checkbox/Checkbox.tsx b/packages/react-component-library/src/components/Checkbox/Checkbox.tsx
@@ -30,6 +30,7 @@ export const Checkbox = forwardRef<HTMLInputElement, CheckboxProps>(
       onBlur,
       onChange,
       value,
+      isInvalid,
       ...rest
     },
     ref

diff --git a/packages/react-component-library/src/components/CheckboxEnhanced/CheckboxEnhanced.tsx b/packages/react-component-library/src/components/CheckboxEnhanced/CheckboxEnhanced.tsx
@@ -14,6 +14,7 @@ export const CheckboxEnhanced: React.FC<CheckboxEnhancedProps> = ({
   name,
   tabIndex = 0,
   title,
+  isInvalid,
   ...rest
 }) => {
   const ref = useRef(null)

diff --git a/packages/react-component-library/src/components/Radio/Radio.tsx b/packages/react-component-library/src/components/Radio/Radio.tsx
@@ -28,6 +28,7 @@ export const Radio = forwardRef<HTMLInputElement, RadioProps>(
       onChange,
       onBlur,
       value,
+      isInvalid,
       ...rest
     },
     ref

diff --git a/packages/react-component-library/src/components/RadioEnhanced/RadioEnhanced.tsx b/packages/react-component-library/src/components/RadioEnhanced/RadioEnhanced.tsx
@@ -14,6 +14,7 @@ export const RadioEnhanced: React.FC<RadioEnhancedProps> = ({
   name,
   tabIndex = 0,
   title,
+  isInvalid,
   ...rest
 }) => {
   const ref = useRef(null)

diff --git a/packages/react-component-library/src/enhancers/__tests__/withFormik.test.tsx b/packages/react-component-library/src/enhancers/__tests__/withFormik.test.tsx
@@ -6,7 +6,7 @@ import { FieldProps } from '../../common/FieldProps'
 import { FormProps } from '../../common/FormProps'
 import { withFormik } from '../withFormik'
 
-const DummyComponent: React.FC = (props) => (
+const DummyComponent: React.FC = ({ isInvalid, ...props }: any) => (
   <div data-testid="dummy-component" {...props} />
 )
 const DummyFormikComponent = withFormik(DummyComponent)
-Original file line number
+Diff line change
@@ Expand Up @@
           onBlur,
           onChange,
           value,
+          isInvalid,
           ...rest
         },
         ref
@@ Expand Down @@