Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): validation error ExtractErrors method should not bail at missing top level fields #262

Closed
mike-winberry opened this issue Jun 13, 2024 · 0 comments · Fixed by #263
Assignees
Labels
bug Something isn't working triage Awaiting triage from the team

Comments

@mike-winberry
Copy link
Collaborator

Environment

App version: 0.4.2

Steps to reproduce

  1. This is currently unreproducable except when used as a library
  2. see feat(common): json schema linting for common validation(s) lula#473 src/pkg/common/schema/schema.go

Expected result

  • get a proper error returned from validation.ExtractErrors

Actual Result

  • get a json null value

Severity/Priority

  • Not directly effecting the functionality of gooscal but does have a negative side effect when extending the library.
@mike-winberry mike-winberry added possible-bug Something may not be working bug Something isn't working and removed possible-bug Something may not be working labels Jun 13, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Jun 13, 2024
@mike-winberry mike-winberry self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Awaiting triage from the team
Projects
Archived in project
1 participant