fix(test): updated uuid in kyverno validation

[CloudBeard]

Description

The Kyverno validation UUID in the dev-validate e2e folder was an incorrect UUID. It needed to start with a 4 in the 3rd set of characters and had an extra character at the end.

The Composition test uses the remote location of https://raw.githubusercontent.com/defenseunicorns/lula/main/src/test/e2e/scenarios/dev-validate/validation.kyverno.yaml to get the validation during compose so the composed artifact is invalid because of the UUID of the validation.

The bad UUID caused the error when the file is linted.

By changing the UUID it fixes the issues in the composed artifact which fixes the test that is ran by the compose_test.go which composed the OSCAL files in the src/test/unit/common/composition test directory.

Related Issue

Fixes #
#538 by updating the incorrect UUID in the file used for testing.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist before merging

• Test, docs, adr added or updated as needed
• Schema Updates applied
• Contributor Guide Steps followed

[CloudBeard]

E2E will fail until this fix is pushed to main.

lula/src/test/unit/common/composition/component-definition-local-and-remote.yaml

Line 43 in 575500e

- href: https://raw.githubusercontent.com/defenseunicorns/lula/main/src/test/e2e/scenarios/dev-validate/validation.kyverno.yaml

The compose is testing local and remote OSCAL and this component-definition is looking at main and this change isn't there yet. Should be updated once and good to go.

Maybe pin a version once fixed and track with renovate? I think main is fine, shouldn't change much.

[brandtkeller]

E2E will fail until this fix is pushed to main.

lula/src/test/unit/common/composition/component-definition-local-and-remote.yaml

Line 43 in 575500e

- href: https://raw.githubusercontent.com/defenseunicorns/lula/main/src/test/e2e/scenarios/dev-validate/validation.kyverno.yaml

The compose is testing local and remote OSCAL and this component-definition is looking at main and this change isn't there yet. Should be updated once and good to go.

Maybe pin a version once fixed and track with renovate? I think main is fine, shouldn't change much.

There is a gap here for testing against main resources and doing feature development. Someone may unknowingly introduce a change to a file that is not picked-up until merge to main has happened.

Some of this can be resolved with ensuring we have insights to valid testing files actually being valid (linted etc) and remaining that way. We should file an issue that looks at some method for classifying a file as a valid artifact (possibly filename identifier) and performs some linting to ensure they stay valid.

[brandtkeller]

Appreciate jumping to get this fixed. Only other comment I would make is additional context to assist reviews; you've got:

• What is the problem
• Where does it exist
• Why does it exist

The only missing piece of value is 'How to validate the changes'.

[CloudBeard]

Verification of fix.

First screenshot is the fail in the E2E testing GitHub workflow. The test that is failing is the TestComponentDefinition in the src/cmd/tools/compose_test.go

Fix screenshots below show the src/test/unit/common/composition/component-definition-local-and-remote.yaml changed the url to this pr branch as the remote source and re-running the test specifically. (had some issues running make test but I believe thats something on machine vs the actual environment, more failing there than in CI)