Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate): save validation resources #612

Merged
merged 21 commits into from
Sep 23, 2024

Conversation

meganwolf0
Copy link
Collaborator

Description

Adds a flag save-resources to validate to save the resources to the backmatter of an assessment result

Related Issue

Relates to #301

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 linked an issue Aug 26, 2024 that may be closed by this pull request
@meganwolf0 meganwolf0 linked an issue Aug 28, 2024 that may be closed by this pull request
@meganwolf0 meganwolf0 changed the title feat(validate): resources added to backmatter feat(validate): save validation resources Aug 28, 2024
@meganwolf0 meganwolf0 marked this pull request as ready for review August 29, 2024 12:41
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting for posterity:

Moving forward with consideration of the use of back matter more carefully. If we can meet our outcomes with a separate external file as-is today - we should execute on that strategy now while evaluating whether we continue to repeat the back matter storage pattern.

@meganwolf0 meganwolf0 marked this pull request as draft September 3, 2024 14:36
@meganwolf0
Copy link
Collaborator Author

Removed back-matter option and associated code changes needed, definitely simplifies things!

@meganwolf0 meganwolf0 marked this pull request as ready for review September 3, 2024 15:07
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few items to cleanup. Also understand this was a discovery and exploration driven PR as opposed to a direct issue deliverable - so I have no issues with undocumented requirements/additions (in the issue).

src/cmd/validate/validate.go Show resolved Hide resolved
src/cmd/evaluate/evaluate.go Outdated Show resolved Hide resolved
src/pkg/common/oscal/assessment-results.go Outdated Show resolved Hide resolved
src/pkg/common/oscal/assessment-results.go Show resolved Hide resolved
src/pkg/common/oscal/assessment-results.go Show resolved Hide resolved
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
@meganwolf0 meganwolf0 marked this pull request as draft September 10, 2024 19:23
@brandtkeller brandtkeller linked an issue Sep 18, 2024 that may be closed by this pull request
@meganwolf0 meganwolf0 marked this pull request as ready for review September 20, 2024 15:22
@brandtkeller brandtkeller merged commit 7b9a771 into main Sep 23, 2024
5 checks passed
@brandtkeller brandtkeller deleted the 301-save-validation-resources branch September 23, 2024 16:13
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Save resources from validation execution Standardized Output for file write
2 participants