feat(kubernetes): support running both create resources and resources in the kubernetes spec #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganwolf0
changed the title
meganwolf0
force-pushed
the
531-support-running-both-create-resources-and-resources-in-the-kubernetes-spec
branch
from
c090cc6
to
64734c7
Compare
…d-resources-in-the-kubernetes-spec
…d-resources-in-the-kubernetes-spec
brandtkeller
approved these changes
Oct 11, 2024
brandtkeller
deleted the
531-support-running-both-create-resources-and-resources-in-the-kubernetes-spec
branch
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds operations to support create -> wait -> read
validateAndGetGVRdoesn't have the correct Group value, so more learning possibly there as to why - so this had passed with a basic "pod" but not with something more complex like a deployment)GetResourcesto evaluate CreateResources -> Wait -> Resources, combining the create and resources into a finaltypes.DomainResources. Based on the combining (just a simple map merge) the keys (names) between the two need to be uniquetypes->specfollowing the discussion on naming clarityRelated Issue
Fixes #531
Type of change
Checklist before merging