Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes)!: wait logic kubernetes version support #718

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

meganwolf0
Copy link
Collaborator

Description

  • Modifies the connect and wait logic to use unicorn k8s pkg - should address the k8s version support bug that the core of this issue is concerned with
  • Refactors creation of cluster so as to not duplicate connect invocations
  • Proposal of modification to wait schema to be more aligned to resource-rule (since all the kind logic is no longer needed - also makes it easier to validate user inputs before passing to wait routine):
domain:
  type: kubernetes
  kubernetes-spec:
    wait:                               # Optional - Group of resources to read from Kubernetes
      group:                            # Optional - Empty or "" for core group
      version: v1                       # Required - Version of resource
      resource: pods                    # Required - Resource type (API-recognized type, not Kind)Required - Resource type (API-recognized type, not Kind)
      name: test-pod-wait               # Required - Name of the resource to wait for
      namespace: validation-test        # Optional - For namespaced resources
      timeout: 30s                      # Optional - Defaults to 30s
    resources:
    - name: podsvt
      resource-rule:
        group:
        version: v1
        resource: pods
        namespaces: [validation-test]

Related Issue

Fixes #229

Type of change

  • Bug fix (breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 marked this pull request as ready for review October 9, 2024 11:57
@meganwolf0 meganwolf0 requested a review from a team as a code owner October 9, 2024 11:57
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciative of native existence support. Can we include updates the go mod/sum as I imagine there are items we can remove from our dependency surface with these changes.

@brandtkeller brandtkeller merged commit cc06251 into main Oct 9, 2024
5 checks passed
@brandtkeller brandtkeller deleted the 229-wait-logic-kubernetes-version-support branch October 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Wait logic kubernetes version support
3 participants