Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate archiver/v3 and archiver/v4 #1042

Open
catsby opened this issue Dec 17, 2024 · 0 comments
Open

Consolidate archiver/v3 and archiver/v4 #1042

catsby opened this issue Dec 17, 2024 · 0 comments

Comments

@catsby
Copy link
Collaborator

catsby commented Dec 17, 2024

Describe what should be investigated or refactored

We're using both archiver/v3 and archiver/v4, and we should just use one of them unless it's absolutely necessary to continue using v3.

Links to any relevant code

As of Dec. 17th, 2024:

tasks.yaml
28:      - cmd: go list -f '{{.Version}}' -m github.com/mholt/archiver/v3

src/test/e2e/zarf_test.go
52:         args:        args{tool: "archiver", toolRepo: "github.com/mholt/archiver/v3"},

src/pkg/bundle/publish.go
17: av3 "github.com/mholt/archiver/v3"

src/pkg/bundle/tarball.go
21: av3 "github.com/mholt/archiver/v3"

It looks like src/pkg/bundle/tarball.go is the only file where they are both used:

av3 "github.com/mholt/archiver/v3"
av4 "github.com/mholt/archiver/v4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant