Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bundle arch against cluster arch #656

Closed
UncleGedd opened this issue Jun 3, 2024 · 3 comments · Fixed by #657
Closed

Check bundle arch against cluster arch #656

UncleGedd opened this issue Jun 3, 2024 · 3 comments · Fixed by #657
Assignees
Labels
possible-bug Something may not be working

Comments

@UncleGedd
Copy link
Collaborator

UncleGedd commented Jun 3, 2024

Environment

Steps to reproduce

Assume my cluster arch is amd64 and I'm deploying from my arm64 Mac. Consider the following:

# uds-bundle.yaml
kind: UDSBundle
metadata:
  name: ghcr-test
  description: testing a bundle of pkgs from ghcr
  version: 0.0.1

packages:
  - name: podinfo
    repository: ghcr.io/defenseunicorns/uds-cli/podinfo
    ref: 0.0.1
  - name: nginx
    repository: ghcr.io/defenseunicorns/uds-cli/nginx
    ref: 0.0.1

---
# tasks.yaml
  tasks:
  - name: default
    actions:
      - cmd: ./uds create . -a amd64 --confirm --no-progress
      - task: deploy

  - name: deploy
    actions:
      - cmd: |
          set -x
          ./uds deploy $(ls -tr uds-bundle*.tar.zst | tail -1) --confirm --no-progress

Expected result

When running uds run the bundle creates and deploys successfully

Actual Result

Bundle create works but on deploy we get this error:

          ERROR:  Failed to validate bundle: arch arm64 does not match cluster arch, [amd64]
     ERROR:  Failed to run action: command "set -x; ./uds deploy $(ls -tr uds-bundle*.tar.zst | tail ..." timed
             out after 0 seconds

It appears that UDS CLI is checking the user's system arch against the cluster arch

Additional Context

The workaround is to simply add -a amd64 to the uds deploy command, but this behavior is still bad. During deploy we should check the bundle's arch against the cluster's arch

@UncleGedd UncleGedd added the possible-bug Something may not be working label Jun 3, 2024
@beholdenkey
Copy link
Contributor

I started thinking I was crazy and that something was wrong with my configuration.

@UncleGedd
Copy link
Collaborator Author

I started thinking I was crazy and that something was wrong with my configuration.

Sorry about that @beholdenkey ! We should have a fix in the next release, shooting for early next week

@beholdenkey
Copy link
Contributor

I started thinking I was crazy and that something was wrong with my configuration.

Sorry about that @beholdenkey ! We should have a fix in the next release, shooting for early next week

Its all good @UncleGedd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants