chore: matrix testing pre-existing k3d clusters

[catsby]

Description

Cleanup some of our GitHub Actions, and run (some of?) our e2e tests in a matrix where one scenario we have k3d installed and a cluster created, and another with k3d installed and no cluster created.

Note about our setup-golang action: I noticed that we were using setup-go to install go 1.21.x, however the setup-go action does not list the .x syntax as supported. Furthermore our go.mod file says go 1.22.4, so the setup go action was setting 1.21.x, and then immediately switching to go 1.22.4 because that's what our go.mod says. The result was a long list of errors trying to use 1.22 because it was being pulled from cache but conflicted with the 1.21 we just setup.

See here for example: https://github.com/defenseunicorns/uds-cli/actions/runs/11037302233/job/30657907519#step:3:102

Note about our setup-from-previous action: I noticed that every invocation was preceded by a checkout action, and the first step of setup-from-previous was also a checkout.

See here and here for example of trying to checkout the repo 2x in the same job

Related Issue

Fixes #940

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Other (security config, docs update, etc)

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[catsby]

Open to suggestions on naming here, but basically wanted to convey that one matrix test operates by installing k3d and creating a cluster, while the other specifically does not create the cluster.

[mjnagel]

Would it be clearer if this were just existing-cluster as a true/false and then pass the inverse to the action below? I'm not a big fan of the second matrix parameter here when it's really the same as the first just different name and truthy vs descriptive string.

Edit: forgot that the matrix value gets used in the job name when viewing it, so true/false would be a bit weird and unhelpful there. But maybe could still delete the second matrix param and use a string equality check below to pass true/false into the action?

[catsby]

forgot that the matrix value gets used in the job name when viewing it, so true/false would be a bit weird and unhelpful there.

Maybe this depends on how it's named? In this case, the label is being used, not the value:

But maybe I'm misunderstanding what you're saying here, I'm not fully versed in GitHub Actions these days

[catsby]

ah ok re-reading this I believe you're referring to existing-cluster: [with-cluster, without-cluster], I thought you were referring to the include: part.

[mjnagel]

Added suggestions that I think would work? Would also need to do the same on the release test of course, but wanted to add for your thoughts.

[catsby]

@mjnagel I applied your suggestions, thanks! At first run I found the logic was backwards (with- did not create a cluster, but without- did) so I swapped it in e1c460c which I believe is correct now. Watching CI run..

[UncleGedd]

love the matrix strategy 🚀