Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: add shell linting to uds-common linting #258

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 3, 2024

This adds shellcheck for linting shell scripts in UDS Packages.

Caution

⚠️ BREAKING CHANGE - shellcheck is on by default and will now fail linting if a package has scripts that do not comply.

@Racer159 Racer159 requested review from a team as code owners October 3, 2024 19:30
tasks/lint.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@daveworth daveworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this - shellcheck is in my list of preferred linters but was not sure how it would fit into Yaml like this - great work

@Racer159 Racer159 self-assigned this Oct 3, 2024
@Racer159
Copy link
Contributor Author

Racer159 commented Oct 3, 2024

(scan lint is blocked until uds cli update comes through #254)

andrewg-xyz
andrewg-xyz previously approved these changes Oct 4, 2024
zachariahmiller
zachariahmiller previously approved these changes Oct 4, 2024
@Racer159 Racer159 changed the title chore: add shell linting to uds-common linting chore!: add shell linting to uds-common linting Oct 4, 2024
@Racer159 Racer159 merged commit 82e9137 into main Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants