Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation handling of SSO secret #535

Closed
mjnagel opened this issue Jul 2, 2024 · 3 comments · Fixed by #578
Closed

Generation handling of SSO secret #535

mjnagel opened this issue Jul 2, 2024 · 3 comments · Fixed by #578
Assignees
Labels
bug Something isn't working operator Issues pertaining to the UDS Operator (Pepr) sso Issues related to the SSO stack (Keycloak/Authservice)

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jul 2, 2024

          @mjnagel - per our convo, perhaps we ought to do [something similar to what is done with netpols](https://github.com/defenseunicorns/uds-core/blob/main/src/pepr/operator/controllers/network/policies.ts#L95)  with generation

Originally posted by @MxNxPx in #511 (comment)

@mjnagel mjnagel added possible-bug Something may not be working operator Issues pertaining to the UDS Operator (Pepr) sso Issues related to the SSO stack (Keycloak/Authservice) labels Jul 2, 2024
@mjnagel
Copy link
Contributor Author

mjnagel commented Jul 2, 2024

Updating with more context...

Currently we generate a secret as part of the sso flow in the operator. My current understanding is that if someone changed the secretName we would not be cleaning up the previous secret. To handle this we can probably add the generation label and filter to delete orphaned secrets similar to what we do for network policies.

For other cases:

  • the client is updated but secret name stays the same, secret is updated, no need to cleanup
  • client is deleted, ownership linking will cleanup the secret for us

@mjnagel
Copy link
Contributor Author

mjnagel commented Jul 2, 2024

Specific behavior we can mimic here (links for network policies):

@mjnagel mjnagel added bug Something isn't working and removed possible-bug Something may not be working labels Jul 15, 2024
@mjnagel mjnagel self-assigned this Jul 15, 2024
@mjnagel
Copy link
Contributor Author

mjnagel commented Jul 15, 2024

Confirmed this is a bug, working to add the generation / purge logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working operator Issues pertaining to the UDS Operator (Pepr) sso Issues related to the SSO stack (Keycloak/Authservice)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant