fix: validate packages using full resource name #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
approved these changes
Sep 18, 2024
mjnagel
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.27.1](v0.27.0...v0.27.1) (2024-09-18) ### Bug Fixes * validate packages using full resource name ([#775](#775)) ([678ed44](678ed44)) ### Miscellaneous * allow service ports to be overridden in test bundles ([#765](#765)) ([5f9a920](5f9a920)) * **deps:** update authservice to v1.0.2 ([#738](#738)) ([3328b08](3328b08)) * **deps:** update githubactions ([#762](#762)) ([c7bab2a](c7bab2a)) * **deps:** update grafana curl image to v8.10.1 ([#773](#773)) ([0d56ef2](0d56ef2)) * **deps:** update istio to v1.23.1 ([#744](#744)) ([f222ea3](f222ea3)) * **deps:** update neuvector chart to 2.7.9 ([#750](#750)) ([a97b509](a97b509)) * **deps:** update neuvector updater image to v8.10.1 ([#774](#774)) ([2afddfc](2afddfc)) * **deps:** update pepr to 0.36.0 ([#696](#696)) ([2a1591e](2a1591e)) * **deps:** update prometheus-stack ([#743](#743)) ([61f7a60](61f7a60)) * **deps:** update test-infra random provider to v3.6.3 ([#753](#753)) ([009326d](009326d)) * **deps:** update uds-identity-config version to 0.6.3 ([#772](#772)) ([a2ad936](a2ad936)) * **deps:** update uds-k3d to v0.9.0 (1.30.4 k3s), k3d to 5.7.4 ([#770](#770)) ([20656e6](20656e6)) * **deps:** update velero kubectl image to v1.31.1 ([#763](#763)) ([56b3a21](56b3a21)) * **deps:** update velero kubectl to v1.31.1 ([#757](#757)) ([c15d77e](c15d77e)) * remove unused neuvector exporter ([#768](#768)) ([bd4f5cf](bd4f5cf)) * task for custom pepr ([#766](#766)) ([e624d73](e624d73)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deploying a uds package to a cluster that has an existing package resource type (such as an eks-d management cluster with eks-anywhere installed in it) that is higher priority than uds-packages, package validation hangs forever since it is waiting on the wrong resource type.
This PR updates the onDeploy/after actions to wait for
packages.uds.devinstead of justpackagesto avoid this conflict.Type of change
Checklist before merging