Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerScale Replication - Reprotect should NOT be calling allow_write_revert #532

Closed
santhoshatdell opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
area/csm-replication Issue pertains to the CSM Replication module type/feature A feature. This label is applied to a feature issues.
Milestone

Comments

@santhoshatdell
Copy link
Contributor

santhoshatdell commented Nov 3, 2022

Bug Description

Current implementation of reprotect:

  1. Initial check: the policy has to be write enabled at the local site.
  2. If the remote site has policy enabled (unplanned failover), disable the policy.
  3. Verify that a SyncIQ policy exists on the local, and create one if it does not.
  4. Enable the policy on the local.
  5. Disallow write on remote (allow_write_revert).

As being discussed in 518(#518), allow_write_revert action on the remote policy (step-5) will delete the directory and gets recreated by the source's SynIQ policy.
This is not the right step to be performed and needs to be investigated. Further, there will be issues with existing NFS export due to recreation.

Logs

POST /platform/11/sync/jobs/ {"action":"allow_write_revert","id":"csi-default--Five_Minutes"}

This request to the API is what causes a deletion of the data before it gets recreated.

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

  • Install driver with replication enabled,
  • Provision volume to Pod using the storage class with replication enabled,
  • Use repctl to initiate failover at the target k8s cluster.
  • Then run reprotect to make the target as new source.

Expected Behavior

Reprotect should not be calling allow_write_revert and should be executing the right steps in the right order.

CSM Driver(s)

CSI Driver for PowerScale v2.4

Installation Type

Helm v3

Container Storage Modules Enabled

Replication v1.3

Container Orchestrator

Kubernetes 1.24.3

Operating System

RHEL 8.4

@santhoshatdell santhoshatdell added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Nov 3, 2022
@santhoshatdell santhoshatdell self-assigned this Nov 3, 2022
@santhoshatdell santhoshatdell added the area/csm-replication Issue pertains to the CSM Replication module label Nov 3, 2022
@csmbot
Copy link
Collaborator

csmbot commented Nov 3, 2022

@santhoshatdell: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at karavi@dell.com.

@santhoshatdell santhoshatdell added backlog and removed needs-triage Issue requires triage. labels Nov 3, 2022
@gallacher gallacher added this to the v1.6.0 milestone Nov 29, 2022
@harshaatdell
Copy link

The reprotect functionality is currently not supported for PowerScale. The implementation that was calling the "allow_write_revert" operation is removed. We will be reimplementing the reprotect functionality as a enhancement.

@harshaatdell harshaatdell added type/feature A feature. This label is applied to a feature issues. and removed type/bug Something isn't working. This is the default label associated with a bug issue. labels Dec 5, 2022
@shaynafinocchiaro shaynafinocchiaro changed the title [BUG]: PowerScale Replication - Reprotect should NOT be calling allow_write_revert PowerScale Replication - Reprotect should NOT be calling allow_write_revert Dec 14, 2022
@harshaatdell harshaatdell modified the milestones: v1.6.0, v1.7.0 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csm-replication Issue pertains to the CSM Replication module type/feature A feature. This label is applied to a feature issues.
Projects
None yet
Development

No branches or pull requests

4 participants