Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dkms.conf directive for ignoring module build failures? #363

Open
anbe42 opened this issue Nov 24, 2023 · 1 comment
Open

New dkms.conf directive for ignoring module build failures? #363

anbe42 opened this issue Nov 24, 2023 · 1 comment

Comments

@anbe42
Copy link
Contributor

anbe42 commented Nov 24, 2023

Originally reported here: https://bugs.debian.org/1038156

For some "optional" modules (i.e. something not preventing booting because the rootfs cannot be mounted or the network cannot be brought up), people would like dkms to ignore build/install failures and not propagate them as errors (and therefore not "break" package installation etc.).

This could be done by adding a new directive to dkms.conf, but I'm unsure how to name that.

For actual usage, I'd prefer this flag to be set by the local admin in /etc/dkms/$module.conf and not shipped with the dkms module in dkms.conf. (Could this usage even be enforced when dkms reads the conffiles?) Deciding whether a (missing) module is (not) critical should be left to the local admin.

With my QA hat on, I'd like to "forbid" usage of such an ignore flag (or globally override it to "off"), as e.g. CI should always signal build failures.

I'll probably not spend time on implementing this.

@evelikov
Copy link
Collaborator

Tl:Dr: Love your proposal, doubt I'll have any time to hack on it.

The only naming idea that comes to mind is BUILD_MAY_FAIL. Better options would be appreciated.

On the handling: using /etc/dkms/$module.conf /etc/dkms/$module-$version.conf ... instead of the dkms.conf shipped with the module is great idea. Note that we currently don't distinguish between the two config (sets), so that'll need polishing.

As you mentioned, we'd also want a global toggle via /etc/dkms/framework.conf to disable these say BUILD_IS_FATAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants