Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing to Delta Lake page to delta.io #141

Closed
dennyglee opened this issue Sep 7, 2022 · 5 comments
Closed

Add contributing to Delta Lake page to delta.io #141

dennyglee opened this issue Sep 7, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@dennyglee
Copy link
Collaborator

Currently, the Delta Lake contributing guide can be found at: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md. As Delta Lake has multiple repos, we need to create a single contributing guide that all repos can point to instead.

@sibyabin
Copy link
Contributor

As per https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors , we probably can create a .github repo at the organization level and add the CONTRIBUTING.md in that. But the question will be does the content of the current contributing guideline covers guidelines of all the repo's in the account or not. If any specific repo's want their own customized contributing guidelines, I assume they can override by placing the same at the individual repo level

@dennyglee
Copy link
Collaborator Author

That's a good call out and worthy of discussion. The main reason for considering to put this on the website (vs. the .github repo of the org level) is because we also have other repos like delta-incubator that are outside of this specific organization but still within the same context of the Delta community. Saying this, it is worth considering doing this and simply having all repos (and the website) point to the org contributing guide.

As for your last point, yes, if there are individual repos that want to add more guidelines, they certainly can but it would be a superset (i.e. not an override).

@sibyabin
Copy link
Contributor

PR #150 created for this

@dennyglee
Copy link
Collaborator Author

Note, keeping this issue open as we need to also update the CONTRIBUTING.md for the various delta-io repos. Thanks @sibyabin for tackling the page!

@dennyglee dennyglee added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Oct 5, 2022
@dennyglee
Copy link
Collaborator Author

Closing per delta-io/kafka-delta-ingest#135 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants